(GH-163) Add aggregate metadata sidecar object and tasks #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some whitespace to fix a rubocop warning.
Previously, to get all metadata information, the sidecar would need to be called multiple times, however, with the puppetstrings featureflag, we can now evaluate the metadata all at once. This commit adds a new object called AggregateMetadata which can hold all of the metadata objects (classes etc.) This commit also adds tests to ensure that it can be serialised and deserialised correctly. And finally this commit changes the puppetstrings helper to use the new aggregate instead of a standard hashtable.
Previously the AggregateMetadata sidecar protocol object was added. This commit adds a default_aggregate and workspace_aggregate sidecar action which will gather all of the metadata in one call. These actions will only be valid with the puppetstrings featureflag. This commt also adds integration tests for these new actions, with and without the featureflag set.
glennsarti
changed the title
glennsarti
force-pushed
the
add-aggregate-metadata
branch
from
7c0f922 to
7e6ac3b
Compare
glennsarti
changed the title
Contributor
Author
|
Self merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Previously, to get all metadata information, the sidecar would need to be called
multiple times, however, with the puppetstrings featureflag, we can now evaluate
the metadata all at once.
This PR adds an AggregateMetadata object and two new tasks
default_aggregateandworkspace_aggregate